Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slack-help-button): added feature flag configurable slack help b… #8957

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Endtry
Copy link
Contributor

@Endtry Endtry commented Oct 4, 2023

Description

In this PR, I added a Slack Help button on the Home Page (top right). The button redirects the user to Datahub's Slack channel on press. There are changes on the server, there's a new feature flag showSlackHelpButton, that defaults to true by default. Setting the flag to false will remove the Slack Button.

Screenshot 2023-10-04 at 3 29 56 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Oct 4, 2023
@xiphl
Copy link
Contributor

xiphl commented Oct 5, 2023

Just a suggestion: Personally, I wouldn't tell my datahub users to go to the Datahub Slack, because they'll be asking things from a non technical perspective. May I suggest leaving the URL to be a configurable setting instead?

@maggiehays
Copy link
Collaborator

Just a suggestion: Personally, I wouldn't tell my datahub users to go to the Datahub Slack, because they'll be asking things from a non technical perspective. May I suggest leaving the URL to be a configurable setting instead?

@xiphl Thanks for the suggestion! I totally see where you're coming from. We're planning on introducing a set of less-technical-focused Slack channels in the upcoming weeks, so I'm hopeful that folks will have a place to engage with and learn from one another :)

We'll keep it configurable with a feature flag for now & can iterate on it as we get feedback from the community!

@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants