feat(ingest): add output schema inference for sql parser #8989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
7 tasks
asikowitz
approved these changes
Oct 12, 2023
Comment on lines
+107
to
+110
| arbitrary_types_allowed=True, | ||
| json_encoders={ | ||
| SchemaFieldDataTypeClass: lambda v: v.to_obj(), | ||
| }, |
There was a problem hiding this comment.
I'm gonna need a mini pydantic tutorial at some point
There was a problem hiding this comment.
I'm honestly not too happy with this setup, but it's fine for now
Comment on lines
+568
to
+575
| # Try to figure out the types of the output columns. | ||
| try: | ||
| statement = sqlglot.optimizer.annotate_types.annotate_types( | ||
| statement, schema=sqlglot_db_schema | ||
| ) | ||
| except sqlglot.errors.OptimizeError as e: | ||
| # This is not a fatal error, so we can continue. | ||
| logger.debug("sqlglot failed to annotate types: %s", e) |
There was a problem hiding this comment.
Could this be slow? I think it'd be nice to only do this if a config option is specified
There was a problem hiding this comment.
this step should be pretty fast
| ), | ||
| # TODO: None of these columns have upstreams? | ||
| # That doesn't seem right - we probably need to add fake schemas for the two tables above. | ||
| cols = [ |
|
Merging through flaky smoke tests. |
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist