Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings/views): enable common user to delete their own views #9000

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(settings/views): enable common user to delete their own views #9000

wants to merge 6 commits into from

Conversation

danielomiya
Copy link

Contextualisation

Currently, common users are unable to delete their own views via the Manage Views page because they miss the MANAGE_GLOBAL_VIEWS platform privilege. In this PR, since the data in this page is from the useListMyViewsQuery, we pass a static isOwnedByUser=true, and add the property down to the component that needs it.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 12, 2023
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ poc-marathon-dec-2023 product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielomiya @maggiehays @chriscollins3456