Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion): file-based state checkpoint provider #9029

Merged
merged 14 commits into from
Nov 10, 2023
Merged

feat(ingestion): file-based state checkpoint provider #9029

merged 14 commits into from
Nov 10, 2023

Conversation

shubhamjagtap639
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 17, 2023
hsheth2
hsheth2 reviewed Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, but broadly looks good

Next step is going to be starting to refactor our stateful ingestion tests to start using this - maybe we can start with the lookml tests

...gestion/src/datahub/ingestion/source/state_provider/file_ingestion_checkpointing_provider.py Outdated Show resolved Hide resolved
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
hsheth2
hsheth2 reviewed Nov 1, 2023
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/dummy.py Outdated Show resolved Hide resolved
...gestion/src/datahub/ingestion/source/state_provider/file_ingestion_checkpointing_provider.py Outdated Show resolved Hide resolved
...gestion/src/datahub/ingestion/source/state_provider/file_ingestion_checkpointing_provider.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/integration/lookml/golden_test_state.json
"state": {
"formatVersion": "1.0",
"serde": "base85-bz2-json",
"payload": "LRx4!F+o`-Q(4)<4JiNuUmt)_WdINa0@Mn>@BivB0a-v1sF;Ar&}h&A0K-EjK*+=xnKU%Oib;?JVrrXB7?aRqCarWwpZm8v5Yh+DsN{|c*msMh9%WJXjKPvIPsDn^@g3;DD9Q9kBh?*|=8M4uRW$_0HKn3XhN;RhAcLIBhLnO2%UA@Ykl;h&Xx(^@2;Y9C#d4g3K_2CA-I*M)h{NMA8Nu4C3XjEQYdh{nR--&lfRUsTL}OOkOO435f=1nKzYJ^9)mbBljM0}gaqy26URw1=q<80Eb9y)y?Vl88kG;g~MToq#r%6tr<yx^i_E#v)8~7vUJum>K9U`U?k}RS<@^?i@<c?y}RaZG9JGf09m`0f!sz%!^wDYcoJR{ix%d2rWCL+XvG>1M1@9*%tk}1N3hRzUaNB"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventually I'd like to change this so that the compression is tied to the state provider, not the checkpoint object - but we can save that for a future PR

...gestion/src/datahub/ingestion/source/state_provider/file_ingestion_checkpointing_provider.py Outdated Show resolved Hide resolved
...gestion/tests/unit/stateful_ingestion/provider/test_file_ingestion_checkpointing_provider.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/unit/stateful_ingestion/state/test_stateful_ingestion.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/unit/stateful_ingestion/state/test_stateful_ingestion.py Outdated Show resolved Hide resolved
hsheth2
hsheth2 reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just a few minor things

...tion/src/datahub/ingestion/source/state_provider/datahub_ingestion_checkpointing_provider.py Show resolved Hide resolved
...tion/src/datahub/ingestion/source/state_provider/datahub_ingestion_checkpointing_provider.py
@@ -17,15 +17,25 @@


class DatahubIngestionStateProviderConfig(IngestionCheckpointingProviderConfig):
datahub_api: Optional[DatahubClientConfig] = DatahubClientConfig()
datahub_api: DatahubClientConfig = DatahubClientConfig()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should remain optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no use of making it optional. It will just add the extra useless if condition of checking datahub_api because of lint error.
Still if it needs to remain optional let me know.

...gestion/src/datahub/ingestion/source/state_provider/file_ingestion_checkpointing_provider.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/unit/stateful_ingestion/provider/test_provider.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/unit/stateful_ingestion/provider/test_provider.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/state/stateful_ingestion_base.py Outdated Show resolved Hide resolved
@hsheth2 hsheth2 changed the title feat(ingestion/state_provider): file-based checkpointing provider integration feat(ingestion): file-based state checkpoint provider Nov 10, 2023
@hsheth2 hsheth2 merged commit a187127 into datahub-project:master Nov 10, 2023
51 checks passed
@shubhamjagtap639 shubhamjagtap639 deleted the file-based-checkpoint-provider branch March 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@asikowitz asikowitz Awaiting requested review from asikowitz

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamjagtap639 @hsheth2 @maggiehays