Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): Apply SearchFlags passed in through to scroll queries #9041

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

iprentic
Copy link
Contributor

In some scroll across lineage queries, the query fails with a 500 from ElasticSearch due to "reason" : "too_complex_to_determinize_exception: Determinizing automaton with 106128 states and 106127 transitions would result in more than 10000 states."

The query has highlighting turned on even though highlighting is not used for this functionality, and in fact, the search flags in the lineage search service have highlighting turned off. This is because the search flags are not properly passed through to the query construction. This PR is to set up passing these flags through.

Tested in quickstart by capturing the query and assuring that it did not have the highlighting part in it.
Tested that this would resolve the issue by capturing the ElasticSearch query and reproducing the error, then removing the highlighting block. The query ran successfully without it.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@iprentic iprentic added the release-0.12.0 PRs targeted for Release 0.12.0 label Oct 18, 2023
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Oct 18, 2023
@iprentic iprentic enabled auto-merge (squash) October 18, 2023 20:06
@iprentic iprentic merged commit 409f981 into master Oct 18, 2023
35 of 36 checks passed
@iprentic iprentic deleted the nd--scroll-flags branch October 18, 2023 21:25
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ product PR or Issue related to the DataHub UI/UX release-0.12.0 PRs targeted for Release 0.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants