Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sample code used for aurora to acryl ingestion #9046

Closed
wants to merge 1 commit into from
Closed

Adding sample code used for aurora to acryl ingestion #9046

wants to merge 1 commit into from

Conversation

vipul094
Copy link

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 18, 2023
@maggiehays maggiehays added community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ labels Oct 23, 2023
hsheth2
hsheth2 reviewed Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome start!

In order to get this merged, we'll need to tweak the code to be implemented as an ingestion source (see https://datahubproject.io/docs/next/metadata-ingestion/adding-source/) and add some tests

@hsheth2 hsheth2 added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Feb 9, 2024
@hsheth2
Copy link
Collaborator

hsheth2 commented Feb 9, 2024

@vipul094 I'm going to close this PR for now. If you get a chance to fix up the code to create a proper datahub ingestion source, please ping us and we can reopen this PR or create a new one.

@hsheth2 hsheth2 closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

Assignees

@hsheth2 hsheth2

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vipul094 @hsheth2 @maggiehays