Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adjust sidebar & create new admin section #9064

Merged
merged 16 commits into from
Nov 10, 2023
Merged

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is failing with a broken link

## Past Meetings
## Town Hall History

See our [Town Hall history](https://www.linkedin.com/company/acryl-data/events/) for the recordings and summaries of the past town halls.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should say "history after X date is here", history before X date is in this markdown doc

we probably shouldn't delete townhall-history.md outright, but we can hide it from the docs site

docs/townhall-history.md Outdated Show resolved Hide resolved
@yoonhyejin yoonhyejin enabled auto-merge (squash) November 10, 2023 06:40
@yoonhyejin yoonhyejin merged commit 9c0f4de into master Nov 10, 2023
31 of 34 checks passed
@yoonhyejin yoonhyejin deleted the docs/move-location branch November 10, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants