Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: unify oidc guides using tabs #9068

Merged
merged 4 commits into from
Nov 2, 2023
Merged

docs: unify oidc guides using tabs #9068

merged 4 commits into from
Nov 2, 2023

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@yoonhyejin yoonhyejin changed the title fix: unify oidc guides using tabs docs: unify oidc guides using tabs Oct 21, 2023
@github-actions github-actions bot added the docs Issues and Improvements to docs label Oct 21, 2023
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
hsheth2
hsheth2 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but looks like the vercel build failed

@yoonhyejin yoonhyejin enabled auto-merge (squash) November 2, 2023 08:07
@yoonhyejin yoonhyejin merged commit f42cb95 into master Nov 2, 2023
32 of 33 checks passed
@yoonhyejin yoonhyejin deleted the docs/oidc-tabs branch November 2, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoonhyejin @hsheth2 @maggiehays