Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): Fix roll back failure when REST_API_AUTHORIZATION_ENABLED is set to true #9092

Conversation

TonyOuyangGit
Copy link
Contributor

The issue detail is in #9088
This proposed fix is to add the DELETE_ENTITY policy to the root user and Admin role so that they should be able to roll back ingestion without explicitly assigning DELETE_ENTITY to themselves when REST_API_AUTHORIZATION_ENABLED is enabled.

Checklist

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Oct 24, 2023
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
@david-leifker david-leifker added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 26, 2023
@david-leifker david-leifker merged commit 12f6fe0 into datahub-project:master Oct 26, 2023
39 checks passed
@TonyOuyangGit TonyOuyangGit deleted the bugfix-add-delete-entity-policy-to-role branch February 14, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants