feat: Add loading indicator to Manage Domains sidebar #9142
Conversation
| </Form.Item> | ||
| </Form> | ||
| <Form component={false}> | ||
| <Form.Item> |
|
maggiehays
added
the
hacktoberfest-accepted
| onFocus={() => setIsFocusedOnInput(true)} | ||
| dropdownStyle={isShowingDomainNavigator ? { display: 'none' } : {}} | ||
| loading={loading} | ||
| disabled={loading} |
There was a problem hiding this comment.
should we definitely disable this if it's not done loading yet? for example, if they want to search for a specific domain, they should probably be able to do that right away?
not blocking
There was a problem hiding this comment.
As soon as the user opens the modal, we kick off an API call to fetch the Domains. Since the user won't be typing anything initially, it can be a bit confusing to see an empty list when they first focus on the search field.
To avoid this confusion, we disable the search field and show a loader to signal that we're in the process of loading the initial list. Once the domains are ready, we enable the search functionality, allowing the user to start their search.
Even while they're searching, if they momentarily pause typing, we have a timer in place to trigger a search API call. During this time, the search field remains disabled with a loader, indicating that we're actively fetching results that match their input.
There was a problem hiding this comment.
This should be resolved now. No longer any disabled state, as discussed during our standup
|
Here the screen shots of PR changes DomainNavigator Empty State
Select options loading indicator Select options Empty State |
|
Looks good - just want to confirm that when user first opens the modal, they will not see a disabled state, right? They should just see loading indicator as we load the browser. |
| > | ||
| {domainSearchOptions} | ||
| {loading ? ( |
Yes we removed the disable state |
Checklist