docs(ingest): inherit capabilities from superclasses #9174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
reviewed
Nov 6, 2023
| @@ -101,6 +101,10 @@ def get_long_description(): | |||
| f"acryl-datahub[testing-utils]{_self_pin}", | |||
| # Extra requirements for loading our test dags. | |||
| "apache-airflow[snowflake]>=2.0.2", | |||
| # Connexion's new version breaks Airflow: | |||
| # See https://github.com/apache/airflow/issues/35234. | |||
There was a problem hiding this comment.
Not a big deal but the period messes up the link on github
| @@ -93,10 +93,20 @@ def capability( | |||
| """ | |||
|
|
|||
| def wrapper(cls: Type) -> Type: | |||
| if not hasattr(cls, "__capabilities"): | |||
| if not hasattr(cls, "__capabilities") or any( | |||
There was a problem hiding this comment.
Can we just use single underscore instead of double underscore here? I think that's why we have to do this in the first place: https://www.scaler.com/topics/double-underscore-python/
There was a problem hiding this comment.
in this case, we actually do want double underscore to signal that it's specific to that class and not subclasses, since the inheritance piece of it we do ourselves using copies to avoid mutating the same underlying object
also the double underscores don't actually get mangled here because we're not within a class context
asikowitz
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes Airflow tests.
Checklist