Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(schema tab): Remove last observed timestamps from schema tab #9188

Merged
merged 5 commits into from
Nov 10, 2023
Merged

refactor(schema tab): Remove last observed timestamps from schema tab #9188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
106fb76
REMOVING LAST OBSERVED
jjoyce0510 Nov 6, 2023
cd37a3e
Merge remote-tracking branch 'acryl/jj--remove-schema-timestamps' int…
jjoyce0510 Nov 6, 2023
1ff68d2
removing unused fields
jjoyce0510 Nov 6, 2023
86a2bf8
Merge remote-tracking branch 'acryl/jj--remove-schema-timestamps' int…
jjoyce0510 Nov 6, 2023
a0b66e7
Merge branch 'master' into jj--remove-schema-timestamps
jjoyce0510 Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions datahub-web-react/src/app/entity/dataset/profile/__tests__/schema/SchemaTimeStamps.test.tsx
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions datahub-web-react/src/app/entity/dataset/profile/schema/components/SchemaHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { SemanticVersionStruct } from '../../../../../../types.generated';
import { toRelativeTimeString } from '../../../../../shared/time/timeUtils';
import { ANTD_GRAY, REDESIGN_COLORS } from '../../../../shared/constants';
import { navigateToVersionedDatasetUrl } from '../../../../shared/tabs/Dataset/Schema/utils/navigateToVersionedDatasetUrl';
import SchemaTimeStamps from './SchemaTimeStamps';
import getSchemaFilterFromQueryString from '../../../../shared/tabs/Dataset/Schema/utils/getSchemaFilterFromQueryString';

const SchemaHeaderContainer = styled.div`
Expand Down Expand Up @@ -137,8 +136,6 @@ type Props = {
hasKeySchema: boolean;
showKeySchema: boolean;
setShowKeySchema: (show: boolean) => void;
lastUpdated?: number | null;
lastObserved?: number | null;
selectedVersion: string;
versionList: Array<SemanticVersionStruct>;
showSchemaAuditView: boolean;
Expand All @@ -158,8 +155,6 @@ export default function SchemaHeader({
hasKeySchema,
showKeySchema,
setShowKeySchema,
lastUpdated,
lastObserved,
selectedVersion,
versionList,
showSchemaAuditView,
Expand Down Expand Up @@ -255,7 +250,6 @@ export default function SchemaHeader({
)}
</LeftButtonsGroup>
<RightButtonsGroup>
<SchemaTimeStamps lastObserved={lastObserved} lastUpdated={lastUpdated} />
<Tooltip title={schemaAuditToggleText}>
<SchemaAuditButton
type="text"
Expand Down
64 changes: 0 additions & 64 deletions datahub-web-react/src/app/entity/dataset/profile/schema/components/SchemaTimeStamps.tsx
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions datahub-web-react/src/app/entity/shared/tabs/Dataset/Schema/SchemaTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,6 @@ export const SchemaTab = ({ properties }: { properties?: any }) => {
return groupByFieldPath(filteredRows, { showKeySchema });
}, [showKeySchema, filteredRows]);

const lastUpdated = getSchemaBlameData?.getSchemaBlame?.version?.semanticVersionTimestamp;
const lastObserved = versionedDatasetData.data?.versionedDataset?.schema?.lastObserved;

const schemaFieldBlameList: Array<SchemaFieldBlame> =
(getSchemaBlameData?.getSchemaBlame?.schemaFieldBlameList as Array<SchemaFieldBlame>) || [];

Expand All @@ -167,8 +164,6 @@ export const SchemaTab = ({ properties }: { properties?: any }) => {
hasKeySchema={hasKeySchema}
showKeySchema={showKeySchema}
setShowKeySchema={setShowKeySchema}
lastObserved={lastObserved}
lastUpdated={lastUpdated}
selectedVersion={selectedVersion}
versionList={versionList}
showSchemaAuditView={showSchemaAuditView}
Expand Down
Loading