Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui) Update Apollo cache to work with union types #9193

Conversation

chriscollins3456
Copy link
Collaborator

Dynamically generate possible types that we pass into our Apollo cache so we can cache union types properly. Previously, Apollo cache simply wouldn't cache anything that was based on a union field, making it very difficult to use.

Here are some docs on the new library added that allows us to get these union types using our existing apollo auto-gen tool: https://the-guild.dev/graphql/codegen/plugins/other/fragment-matcher

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 6, 2023
@jjoyce0510 jjoyce0510 merged commit 88cde08 into datahub-project:master Nov 7, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants