Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ingestion overview pages #9210

Merged
merged 14 commits into from
Nov 20, 2023
Merged

feat: add ingestion overview pages #9210

merged 14 commits into from
Nov 20, 2023

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Nov 9, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

This PR needs to be merged first ; datahub-project/static-assets#61

Separating "Introduction to ingestion" page to following pages ;

  • Ingestion overview
  • Recipe overview
  • Source overview
  • Sink overview
  • CLI ingestion guide

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 9, 2023
@yoonhyejin yoonhyejin changed the title fix: add ingestion overview pages feat: add ingestion overview pages Nov 9, 2023
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/source_overview.md Outdated Show resolved Hide resolved
metadata-ingestion/source_overview.md Outdated Show resolved Hide resolved
metadata-ingestion/sink_overview.md Show resolved Hide resolved
server: "http://localhost:8080"
```

A number of recipes are included in the [examples/recipes](./examples/recipes) directory. For full info and context on each source and sink, see the pages described in the [table of plugins](../docs/cli.md#installing-plugins).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that table is kinda out of date - ideally we should be autogenerating it too

metadata-ingestion/recipe_overview.md Show resolved Hide resolved
metadata-ingestion/recipe_overview.md Show resolved Hide resolved
metadata-ingestion/recipe_overview.md Show resolved Hide resolved
metadata-ingestion/recipe_overview.md Outdated Show resolved Hide resolved
@yoonhyejin
Copy link
Collaborator Author

@hsheth2 Thanks for the feedbacks! Made some changes

Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a bunch of tiny nits, but mostly looking good

metadata-ingestion/README.md Outdated Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/README.md Show resolved Hide resolved
metadata-ingestion/source_overview.md Outdated Show resolved Hide resolved
metadata-ingestion/source_overview.md Outdated Show resolved Hide resolved
metadata-ingestion/sink_overview.md Outdated Show resolved Hide resolved
metadata-ingestion/sink_overview.md Outdated Show resolved Hide resolved
metadata-ingestion/sink_overview.md Show resolved Hide resolved
metadata-ingestion/sink_overview.md Outdated Show resolved Hide resolved
@yoonhyejin yoonhyejin merged commit 1ad4f96 into master Nov 20, 2023
51 of 52 checks passed
@yoonhyejin yoonhyejin deleted the docs/ingestion-guide branch November 20, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants