Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ingest): fix typo in snowflake ingestion docs #9239

Merged
merged 1 commit into from
Nov 15, 2023
Merged

docs(ingest): fix typo in snowflake ingestion docs #9239

merged 1 commit into from
Nov 15, 2023

Conversation

PGuiv
Copy link
Contributor

@PGuiv PGuiv commented Nov 14, 2023 •
edited by hsheth2
Loading

This should fix #9238

Screenshot 2023-11-14 at 9 51 04 AM

This is my first PR in the DataHub Open Source project. I tried to followed the contributors guidelines, but let me know if I missed anything here.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • n/a Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • n/a For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 14, 2023
Jaisung-Huh
Jaisung-Huh approved these changes Nov 14, 2023
View reviewed changes
Copy link

@Jaisung-Huh Jaisung-Huh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@hsheth2 hsheth2 changed the title docs[#9238]: Fix typo in Snowflake ingester doc page docs(ingest): fix typo in Snowflake ingester doc page Nov 14, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Nov 14, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Nov 14, 2023

@PGuiv thanks!

@hsheth2 hsheth2 changed the title docs(ingest): fix typo in Snowflake ingester doc page docs(ingest): fix typo in snowflake ingestion docs Nov 15, 2023
@hsheth2 hsheth2 merged commit 8475fc9 into datahub-project:master Nov 15, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaisung-Huh Jaisung-Huh Jaisung-Huh approved these changes

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in Snowflake ingester doc page
3 participants
@PGuiv @hsheth2 @Jaisung-Huh