-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dataquality aspect): Added Data Quality Metrics aspect to emit data quality metrics metadata into Datahub #9265
base: master
Are you sure you want to change the base?
Conversation
metadata-models/src/main/pegasus/com/linkedin/dataquality/DataQualityDimensionInfo.pdl
Outdated
Show resolved
Hide resolved
metadata-models/src/main/pegasus/com/linkedin/dataquality/DimensionScore.pdl
Outdated
Show resolved
Hide resolved
metadata-models/src/main/pegasus/com/linkedin/dataquality/DimensionScore.pdl
Show resolved
Hide resolved
Hi there! What is the goal with this PR? Adding context in the description will be quite useful! Thanks in advanced |
Hi, PR is about adding Data Quality Metrics capability, working on changes for dynamic Data Quality metrics addition as per PR review comments. Thanks. |
@naresh-angala I know that this PR is just the model changes. Can you attach a documentation link that conveys the big picture and where it all fits please. |
metadata-models/src/main/pegasus/com/linkedin/dataquality/DataQualityDimensionInfo.pdl
Outdated
Show resolved
Hide resolved
metadata-models/src/main/pegasus/com/linkedin/dataquality/SchemaFieldQualityDimensionInfo.pdl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes and clarifications have not been addressed on this PR
Okay, the team will change the PR to Draft and work on the design changes. Thanks. |
This is the data model changes to support the full ability to capture and report data quality dimensions. There was a bit of back and forth in slack back in Oct 2023 on this topic which include example usage screens found here Here was the simple Feature Goal statement: |
@naresh-angala and @rtekal -- where are the graphQL and UI updates related to this feature? Right now this looks like just PDL updates. Without the rest I don't see how datahub gets any value outside of the ability to ingest and store the data which IMHO is pretty basic. |
@sgm44 -- Intial plan was to get the Data quality model changes be reviewed and accepted. |
@jjoyce0510 -- Can you share details on below,
Thanks. |
@jjoyce0510 -- Please provide details on above points. |
@naresh-angala Is there any tentative timeline for this feature to be fully integrated into the UI, GraphQL and backend? This is an integral part of DQ, and would like very much to see this in the newest version |
@naresh-angala told me: Targetting last week of Sep to complete |
091db70
to
eab2ac7
Compare
@jjoyce0510 : Updated the PR with dynamic dimension names and UI changes. Please review. |
Checklist