Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dataquality aspect): Added Data Quality Metrics aspect to emit data quality metrics metadata into Datahub #9265

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

naresh-angala
Copy link

Checklist

  • [ X ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@naresh-angala naresh-angala changed the title feat(Dataquality aspect): Added Data Quality Metrics aspect to emit data quality metrics into Datahub feat(Dataquality aspect): Added Data Quality Metrics aspect to emit data quality metrics metadata into Datahub Nov 17, 2023
@david-leifker david-leifker added the product PR or Issue related to the DataHub UI/UX label Nov 21, 2023
@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Nov 29, 2023
@jjoyce0510
Copy link
Collaborator

Hi there! What is the goal with this PR? Adding context in the description will be quite useful! Thanks in advanced

@naresh-angala
Copy link
Author

Hi there! What is the goal with this PR? Adding context in the description will be quite useful! Thanks in advanced

Hi,

PR is about adding Data Quality Metrics capability, working on changes for dynamic Data Quality metrics addition as per PR review comments.

Thanks.

@rtekal
Copy link
Contributor

rtekal commented Aug 2, 2024

@naresh-angala I know that this PR is just the model changes. Can you attach a documentation link that conveys the big picture and where it all fits please.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes and clarifications have not been addressed on this PR

@rtekal
Copy link
Contributor

rtekal commented Aug 7, 2024

Okay, the team will change the PR to Draft and work on the design changes. Thanks.

@sgm44
Copy link

sgm44 commented Aug 7, 2024

PR is about adding Data Quality Metrics capability, working on changes for dynamic Data Quality metrics addition as per PR review comments.

This is the data model changes to support the full ability to capture and report data quality dimensions. There was a bit of back and forth in slack back in Oct 2023 on this topic which include example usage screens found here

Here was the simple Feature Goal statement:
As a data producer, I want quality metrics for my ingested datasets to display within the dataset view in the catalog so that the metrics are available to data consumers.

@sgm44
Copy link

sgm44 commented Aug 7, 2024

@naresh-angala and @rtekal -- where are the graphQL and UI updates related to this feature? Right now this looks like just PDL updates. Without the rest I don't see how datahub gets any value outside of the ability to ingest and store the data which IMHO is pretty basic.

@naresh-angala
Copy link
Author

@naresh-angala and @rtekal -- where are the graphQL and UI updates related to this feature? Right now this looks like just PDL updates. Without the rest I don't see how datahub gets any value outside of the ability to ingest and store the data which IMHO is pretty basic.

@sgm44 -- Intial plan was to get the Data quality model changes be reviewed and accepted.
Would be updating the code with GraphQL and UI related change subsequently after the model.

@naresh-angala
Copy link
Author

@jjoyce0510 -- Can you share details on below,

  1. Can a feature be contributed with multiple PRs.
  2. If feature need to be contributed with single PR, let us know comments on below approach
    --> Marking this PR in draft mode and add the below changes incrementally,
    a) Dynamic list of Dimensions with new aspect
    b) Mapper changes and GraphQL changes
    c) UI changes to display the quality metrics

Thanks.

@naresh-angala
Copy link
Author

@jjoyce0510 -- Can you share details on below,

  1. Can a feature be contributed with multiple PRs.
  2. If feature need to be contributed with single PR, let us know comments on below approach
    --> Marking this PR in draft mode and add the below changes incrementally,
    a) Dynamic list of Dimensions with new aspect
    b) Mapper changes and GraphQL changes
    c) UI changes to display the quality metrics

Thanks.

@jjoyce0510 -- Please provide details on above points.

@naresh-angala naresh-angala marked this pull request as draft August 26, 2024 08:00
@Curiosity007
Copy link

@naresh-angala Is there any tentative timeline for this feature to be fully integrated into the UI, GraphQL and backend? This is an integral part of DQ, and would like very much to see this in the newest version

@rtekal
Copy link
Contributor

rtekal commented Sep 11, 2024

@naresh-angala told me: Targetting last week of Sep to complete

@naresh-angala naresh-angala reopened this Oct 25, 2024
@github-actions github-actions bot removed the product PR or Issue related to the DataHub UI/UX label Oct 25, 2024
@naresh-angala
Copy link
Author

Requested changes and clarifications have not been addressed on this PR

@jjoyce0510 : Updated the PR with dynamic dimension names and UI changes. Please review.

@naresh-angala naresh-angala marked this pull request as ready for review November 15, 2024 17:30
@naresh-angala
Copy link
Author

UI Screen shots: Dataset metrics: Chart view:
Screenshot 2024-11-15 at 10 25 10 PM

Schemafield metrics:
Screenshot 2024-11-15 at 10 25 18 PM

@naresh-angala
Copy link
Author

UI Screenshots:
Dataset metrics: Table view:

Screenshot 2024-11-15 at 11 03 20 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community poc-marathon-dec-2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.