Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): refactor add and remove Related Terms tab message to showcas… #9338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ui): refactor add and remove Related Terms tab message to showcas… #9338

wants to merge 1 commit into from

Conversation

olgadimova
Copy link
Contributor

…e actual request result

This PR fixes Business Glossary Related Terms bug when successful message was shown even on Add Terms / Remove Term request failed.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

1
2
3
4

After fix:
after

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 Awaiting requested review from chriscollins3456

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
poc-marathon-dec-2023 product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olgadimova @chriscollins3456