Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(openapi): allow Bearer token #9669

Merged
merged 7 commits into from
Feb 11, 2024
Merged

feat(openapi): allow Bearer token #9669

merged 7 commits into from
Feb 11, 2024

Conversation

dim-ops
Copy link
Contributor

@dim-ops dim-ops commented Jan 19, 2024 •
edited
Loading

I need to authenticate with a Bearer token to my APIs.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 19, 2024
@dim-ops dim-ops force-pushed the feat/allow-bearer-token-openapi branch from b495e83 to 162bb0f Compare January 19, 2024 12:01
@dim-ops dim-ops force-pushed the feat/allow-bearer-token-openapi branch 3 times, most recently from 1754819 to e6d37a4 Compare January 19, 2024 14:01
@dim-ops dim-ops marked this pull request as ready for review January 19, 2024 14:02
@dim-ops dim-ops force-pushed the feat/allow-bearer-token-openapi branch from e6d37a4 to b274151 Compare January 19, 2024 15:34
@dim-ops dim-ops force-pushed the feat/allow-bearer-token-openapi branch 2 times, most recently from 8d6660b to de3eddb Compare January 20, 2024 10:05
@dim-ops dim-ops force-pushed the feat/allow-bearer-token-openapi branch 3 times, most recently from 1617a20 to a4aff3f Compare January 20, 2024 13:54
@dim-ops dim-ops force-pushed the feat/allow-bearer-token-openapi branch from 54e13e7 to 62e23ad Compare January 26, 2024 15:18
@dim-ops
Copy link
Contributor Author

dim-ops commented Feb 2, 2024

Up @hsheth2 please 🙏

@hsheth2
Copy link
Collaborator

hsheth2 commented Feb 9, 2024

@dim-ops I made some tweaks to your PR to simplify the code a bit and fix the lint. Let me know if you have any concerns with my changes

@dim-ops
Copy link
Contributor Author

dim-ops commented Feb 10, 2024 •
edited
Loading

It seems great, thank you @hsheth2 😃

@hsheth2 hsheth2 merged commit 709c596 into datahub-project:master Feb 11, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@hsheth2 hsheth2

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dim-ops @hsheth2