feat(airflow) Override datajob external_url #9681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
asikowitz
reviewed
Jan 22, 2024
...data-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/client/airflow_generator.py
Outdated
Show resolved
Hide resolved
hsheth2
reviewed
Jan 25, 2024
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/lineage/datahub.py
Outdated
Show resolved
Hide resolved
...data-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/client/airflow_generator.py
Outdated
Show resolved
Hide resolved
gp1105739
force-pushed
the
peng-airflow-plugin-url
branch
from
b5551c0
to
e981ceb
Compare
hsheth2
reviewed
Feb 5, 2024
...data-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/client/airflow_generator.py
Outdated
Show resolved
Hide resolved
gp1105739
force-pushed
the
peng-airflow-plugin-url
branch
from
7876a9b
to
5083956
Compare
gp1105739
force-pushed
the
peng-airflow-plugin-url
branch
from
596065a
to
8a6efb0
Compare
gp1105739
force-pushed
the
peng-airflow-plugin-url
branch
from
8a6efb0
to
9861d61
Compare
hsheth2
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The current url link may not be that useful for the two reasons following, which is why this pr is brought up.
taskinstance page always times out for us due to the huge amount of DAGs we have.
taskinstance page is less informative compared to DAG page
This PR is about adding a configurable field such that users can choose the url of datajob between the page of taskinstance and grid on airflow.