Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): support jdk8 spark lineage #9697

Merged

Conversation

david-leifker
Copy link
Collaborator

The Spring 6 changes along with the gradle build configuration introduced a situation where all modules were mostly building with the newer jdk17. This was a bug since we still want to rely on jdk11 for modules like the datahub-client. This restores datahub-client to jdk11 as well as support jdk8 for the spark lineage plugin.

This was accomplished with some dynamic logic at the beginning of the main gradle file to determine if there is a Spring 6 or Spring Boot 3 dependency. If so, then jdk17 is the only supported option.

For modules supporting the datahub-client, such as metadata-models, we ensure that the target class version is used with the addition of the jdk8 spark test. If that ci test fails to compile then we've broken an expected jdk constraint.

As a side-effect, instances of source code which moved to newer language specifications was discovered. These instances were downgraded to jdk8 compatible code (only a few items).

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Jan 23, 2024
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see some of the nice JDK17 syntax improvements go :'( but lgtm

@david-leifker david-leifker merged commit 2642788 into datahub-project:master Jan 23, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants