feat(build): support jdk8 spark lineage #9697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Spring 6 changes along with the gradle build configuration introduced a situation where all modules were mostly building with the newer jdk17. This was a bug since we still want to rely on jdk11 for modules like the
datahub-client
. This restoresdatahub-client
to jdk11 as well as support jdk8 for the spark lineage plugin.This was accomplished with some dynamic logic at the beginning of the main gradle file to determine if there is a Spring 6 or Spring Boot 3 dependency. If so, then jdk17 is the only supported option.
For modules supporting the
datahub-client
, such asmetadata-models
, we ensure that the target class version is used with the addition of the jdk8 spark test. If that ci test fails to compile then we've broken an expected jdk constraint.As a side-effect, instances of source code which moved to newer language specifications was discovered. These instances were downgraded to jdk8 compatible code (only a few items).
Checklist