fix(ingest/transformer): generate ownership aspect from handle_end_of_stream #9720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
requested changes
Jan 26, 2024
| transformer = ExtractOwnersFromTagsTransformer.create( | ||
| config, | ||
| PipelineContext(run_id="test"), | ||
| ) | ||
| transformed = list( | ||
|
|
||
| list( | ||
| transformer.transform( | ||
| [ | ||
| RecordEnvelope(dataset, metadata={}), |
There was a problem hiding this comment.
if we put an end of stream record in here, it should do everything right?
I don't think our tests should be calling handle_end_of_stream
…com:sid-acryl/datahub-fork into master+CUS-1183-extract_ownership_from_tags
hsheth2
approved these changes
Jan 31, 2024
hsheth2
added
the
merge-pending-ci
hsheth2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that would cause the existing tags aspect to be overwritten when using
ExtractOwnersFromTagsTransformer