feat(cli): Add support for custom ownership types to dataproduct CLI #9762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
hsheth2
approved these changes
Feb 2, 2024
| @@ -332,6 +336,7 @@ def add_owner(urn: str, owner: str, owner_type: str) -> None: | |||
| if not urn.startswith("urn:li:dataProduct:"): | |||
| urn = f"urn:li:dataProduct:{urn}" | |||
| dataproduct_patcher: DataProductPatchBuilder = DataProduct.get_patch_builder(urn) | |||
| owner_type, owner_type_urn = validate_ownership_type(owner_type) | |||
There was a problem hiding this comment.
is owner_type_urn unused here?
There was a problem hiding this comment.
Good catch, as I mentioned in description, via this command we can not add custom ownership because we are bound by choices list. Nevertheless the variable should not be left unused, I added it to the OwnerClass. Thanks!
|
@hsheth2 All the tests are passing, can we merge the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change allows user to specify
urnof a custom ownership type in thetypefield of the ownership list.The logic is preserved both ways (
from_yamlandfrom_datahub) - there are tests in place for that.Additionally the PR contains fix to some problems in
_patch_ownershipfunction:typedefined thenidwas set wrongly - now it is fixedI decided to keep predefined, enum-based choice list in
dataproduct add_ownercli command - if support of ownership type urn is needed the change is required only within theadd_ownerfunction ofdataproduct_cli.py- I can adjust it in this PR if needed.