Add compaction, rules, dynamic configurations, nativeSpec #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this is really great and helpful. |
AdheipSingh
approved these changes
Jan 11, 2025
controllers/druid/dynamic_config.go
Outdated
| if err != nil { | ||
| emitEvent.EmitEventGeneric( | ||
| druid, | ||
| "GetAuthCredsFailed", |
There was a problem hiding this comment.
where ever emitEventGeneric is called can you use constants.
Refer to https://github.com/datainfrahq/druid-operator/blob/master/controllers/druid/interface.go#L25
There was a problem hiding this comment.
I updated to use new constants. Let me know if it looks good to you. Good callout.
In this same commit I also pinned the version of MinIO being installed in the integration tests. They failed running locally for me and I noticed version 7.0.0 was released < 24h ago https://github.com/minio/operator/releases/tag/v7.0.0
…o use constants, set MinIO version to avoid unexpected breaking upgrades
TessaIO
pushed a commit
to TessaIO/druid-operator
that referenced
this pull request
Jan 26, 2025
…, nativeSpec (datainfrahq#197) * Add compaction, rules, dynamic configurations, nativeSpec * update strings in EmitEventGeneric() calls within dynamic_config.go to use constants, set MinIO version to avoid unexpected breaking upgrades
TessaIO
pushed a commit
to TessaIO/druid-operator
that referenced
this pull request
Jan 26, 2025
…, nativeSpec (datainfrahq#197) * Add compaction, rules, dynamic configurations, nativeSpec * update strings in EmitEventGeneric() calls within dynamic_config.go to use constants, set MinIO version to avoid unexpected breaking upgrades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have a Druid cluster managed with this operator and wanted to change compaction settings, retention rules, dynamic configurations, and define ingestion specs with native kubernetes manifests instead of json to enable further configuration with Infrastructure as Code.
These settings are incorporated into existing Druid and DruidIngestion CRs. Common API logic has been moved into a common module in pkg/ for access across the operator. This includes URL building and Auth logic.
Compaction settings and dynamic configurations are updated based on GET requests to the Druid API rather than storing expected settings in the
statussection of cluster objects. This ensures settings are properly applied even if the Druid cluster state changes or if the Druid cluster doesn't properly persist the values.Documentation has been added for the new features mentioned but also for the existing authentication configuration logic.
This PR has:
Key changed/added files in this PR
apis/druid/v1alpha1/druidingestion_types.gocontrollers/druid/druid_controller.gocontrollers/druid/dynamic_config.gocontrollers/ingestion/reconciler.gopkg/druidapi/druidapi.gopkg/util/util.go