-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingestion Controller #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@itamar-marom @styk-tv @cyril-corbon @cintoSunny @harinirajendran All your initial reviews are welcome ! |
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
itamar-marom
reviewed
May 9, 2023
Ingestion Controller Updates
4 tasks
TessaIO
pushed a commit
to TessaIO/druid-operator
that referenced
this pull request
Jul 24, 2024
* ingestion spec acc to v3 * task creation * supprt native batch * fix router url * revert license change * revert go mod change * fix main * fix: made some changes as per review comments * fix: removed unused package from ingestion reconciler * rebase 1 * add example * add review * update dockerfile --------- Co-authored-by: avtarOPS <[email protected]>
AdheipSingh
added a commit
that referenced
this pull request
Jul 28, 2024
* Ingestion Controller (#53) * ingestion spec acc to v3 * task creation * supprt native batch * fix router url * revert license change * revert go mod change * fix main * fix: made some changes as per review comments * fix: removed unused package from ingestion reconciler * rebase 1 * add example * add review * update dockerfile --------- Co-authored-by: avtarOPS <[email protected]> * Update Docs and Tutorials (#138) * docs and tutorials * Refactor/ordering (#123) * (ordering): refactor code * (ordering): refactor code * (ordering): testing * chore(branch): rebase branch with master * fix(tests): validate nodes order by regex * Bump controller-tools version (#140) * Utilize the DruidIngestion controller in e2e tests (#146) * adds needed volumes to eks deployment spec and improves getting started documentation by noting minio dependency (#149) * Add support for annotations on Deployment/StatefulSet resources in DruidNodeSpec (#145) * Add support for annotations on Deployment/StatefulSet resources * Support setting ReplicationControllerAnnotations at the cluster-level * rename replicationControllerAnnotations to workloadAnnotations * suggestions from code review * Add support for multi tier nodes with different PVC sizes (#106) (#152) Co-authored-by: Farhad Farahi <[email protected]> * fix: put Druid crds in the appropriate folder specified by Helm (#162) Signed-off-by: ahmed.g <[email protected]> Signed-off-by: TessaIO <[email protected]> * Adds service account name to each druid node optionally (#164) * Adds service account to each druid node optionally * Use controller-gen v0.11.2 --------- Signed-off-by: ahmed.g <[email protected]> Signed-off-by: TessaIO <[email protected]> Co-authored-by: AdheipSingh <[email protected]> Co-authored-by: avtarOPS <[email protected]> Co-authored-by: Itamar Marom <[email protected]> Co-authored-by: Jesper Larsson <[email protected]> Co-authored-by: Sam Wheating <[email protected]> Co-authored-by: Evan Jones <[email protected]> Co-authored-by: Farhad Farahi <[email protected]> Co-authored-by: Farhad Farahi <[email protected]> Co-authored-by: Sadananda Aithal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3.
Current State of PR
NativeBatchIndexParallel
Basic-Auth
CRD Definition
Scope
Installation
Ingestion Method Support
Authentication/TLS With Druid
Ingestion Controller
Intro
druidingestion
custom resource.DruidIngestion Custom Resource
State Handling
Controllers are stateless, and custom resource status is used to store and reflect state changes. For each reconcile loop, the state is constructed based on observation.
Flow for creation and updation of druidIngestion CR
Flow for deletion of druidIngestion CR
The Druid service is constructed by getting the router Kubernetes service, and the controller expects the druidCluster name to be present on the CR.
Basic Auth is supported, and users can create a secret and refer to it in the druidIngestion CR. Controllers look up OperatorUserName and OperatorPassword.