Tweak to remote file system caching for improved page loads (#435)

* Revert 8aad9e1 -- slowed page loads down for attached files considerably * Tweak pre-commit
datalab-org · Aug 16, 2023 · 051735c · 051735c
1 parent 8d52337
commit 051735c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -49,6 +49,6 @@ repos:
       - id: generate-schemas
         name: Regenerate item model JSONSchemas
         description: Check if the current code changes have enacted changes to the resulting JSONSchemas
-        entry: pipenv run invoke -r pydatalab dev.generate-schemas
+        entry: invoke -r pydatalab dev.generate-schemas
         pass_filenames: false
         language: python
diff --git a/pydatalab/pydatalab/remote_filesystems.py b/pydatalab/pydatalab/remote_filesystems.py
@@ -96,7 +96,10 @@ def get_directory_structure(
         # then rebuild the cache.
         if (
             (not cached_dir_structure)
-            or cache_age > datetime.timedelta(minutes=CONFIG.REMOTE_CACHE_MAX_AGE)
+            or (
+                invalidate_cache is not False
+                and cache_age > datetime.timedelta(minutes=CONFIG.REMOTE_CACHE_MAX_AGE)
+            )
             or (
                 invalidate_cache
                 and cache_age > datetime.timedelta(minutes=CONFIG.REMOTE_CACHE_MIN_AGE)