Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit uses development ESLint rules rather than prod #895

Open
ml-evs opened this issue Sep 30, 2024 · 0 comments
Open

pre-commit uses development ESLint rules rather than prod #895

ml-evs opened this issue Sep 30, 2024 · 0 comments
Labels
build For issues/PRs pertaining to the build or deployment of the package javascript Pull requests that update Javascript code

Comments

@ml-evs
Copy link
Member

ml-evs commented Sep 30, 2024

As noticed by @BenjaminCharmes, the pre-commit ESLint seems to be using the dev rules rather than prod, so some fixable issues are not being fixed automatically. It seems quite hard to set this manually and none of the workarounds I tried seemed to work; instead we might revert the eslint config changes (i.e., treat most things as errors again) but figure out how to get yarn serve to be more forgiving itself.

@ml-evs ml-evs added build For issues/PRs pertaining to the build or deployment of the package javascript Pull requests that update Javascript code labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build For issues/PRs pertaining to the build or deployment of the package javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

1 participant