Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic data table on collection page #885

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 24, 2024

Closes #815
Closes #891.

Replaces the next table on collections with the new dynamic table, and:

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (a28c0b5) to head (e177fe6).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          62       62           
  Lines        3909     3909           
=======================================
  Hits         2667     2667           
  Misses       1242     1242           

Copy link

cypress bot commented Sep 24, 2024

datalab    Run #2455

Run Properties:  status check passed Passed #2455  •  git commit d699869605 ℹ️: Merge e177fe671432a40cbba1a60c0e0df42bff6f40fd into a28c0b551448f5803317b43e5bfe...
Project datalab
Branch Review ml-evs/add-collection-table
Run status status check passed Passed #2455
Run duration 06m 33s
Commit git commit d699869605 ℹ️: Merge e177fe671432a40cbba1a60c0e0df42bff6f40fd into a28c0b551448f5803317b43e5bfe...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 132
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the ml-evs/add-collection-table branch 2 times, most recently from bf89a07 to 95de17d Compare September 27, 2024 17:10
@ml-evs ml-evs marked this pull request as ready for review September 27, 2024 17:11
@ml-evs ml-evs requested review from BenjaminCharmes and removed request for jdbocarsly September 27, 2024 17:11
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Just a few comments or things to modify maybe?

Perhaps we should either remove the checkboxes column inside CollectionInformation, or add a button to delete multiple items from the collection?

And a small eslint warning inside CollectionInformation.vue because "data" should be above "computed".

webapp/src/components/DynamicDataTable.vue Show resolved Hide resolved
webapp/src/components/CollectionTable.vue Outdated Show resolved Hide resolved
@ml-evs
Copy link
Member Author

ml-evs commented Sep 30, 2024

Thanks Ben, think I've fixed everything

Perhaps we should either remove the checkboxes column inside CollectionInformation, or add a button to delete multiple items from the collection?

I've removed the checkboxes for now, though we might think about a delete button that removes from just a collection, good idea!

And a small eslint warning inside CollectionInformation.vue because "data" should be above "computed".

Just raised #895 for this

BenjaminCharmes
BenjaminCharmes previously approved these changes Oct 1, 2024
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very great ! 🚀

@ml-evs
Copy link
Member Author

ml-evs commented Oct 1, 2024

Think this is ready again when you are @BenjaminCharmes! I added a test to catch the case we discussed (also our first for the collections table/page generally).

Copy link
Contributor

@BenjaminCharmes BenjaminCharmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It look really great, nice one ! 🚀

@ml-evs ml-evs force-pushed the ml-evs/add-collection-table branch from 4d5f3df to e177fe6 Compare October 2, 2024 18:40
@ml-evs
Copy link
Member Author

ml-evs commented Oct 2, 2024

It look really great, nice one ! 🚀

Thanks, I'm going to merge this now but make a mental note that the tests locally might not work every time

@ml-evs ml-evs merged commit ce2f9d0 into main Oct 2, 2024
21 checks passed
@ml-evs ml-evs deleted the ml-evs/add-collection-table branch October 2, 2024 19:02
@ml-evs ml-evs added bug Something isn't working webapp For issues/PRs pertaining to the web interface usability labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working usability webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collections table incorrect link to collection edit page Collection table is currently broken
2 participants