Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring of 'fancy' tables for enhanced re-use #405

Closed
wants to merge 21 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 26, 2023

This PR is blocked by #404.

The overall aim is to make the fancy tables re-usable within collections, with the eventual outcome of replacing the original tables, once testing has been updated.

Also adds

  • Expandable rows

ml-evs added 21 commits May 26, 2023 11:35
- Lots of refactoring to enable external calls of routing functions
- Add ability to create an item that starts in a given collection
- Return collections lookups from item endpoints
- Fix test user ID
- Ensure relationship lookups also check `immutable_id`
- Enable collection blocks for comments and chat
- Adds routes for adding/deleting blocks from a collection
…omponent

- Also fix sizing type mismatch in `UserBubble`
@ml-evs ml-evs added webapp For issues/PRs pertaining to the web interface blocked labels May 26, 2023
@cypress
Copy link

cypress bot commented May 26, 2023

27 failed tests on run #346 ↗︎

27 18 0 0 Flakiness 0

Details:

Merge 9f57700 into a465ea5...
Project: datalab Commit: 7e939d0b8f ℹ️
Status: Failed Duration: 06:30 💡
Started: May 26, 2023 11:43 AM Ended: May 26, 2023 11:49 AM
Failed  batchSampleFeature.cy.js • 1 failed test

View Output Video

Test Artifacts
Batch sample creation > forces submit with a few errors Output Screenshots Video
Failed  editPage.cy.js • 10 failed tests

View Output Video

Test Artifacts
Edit Page > Adds a valid sample Output Screenshots Video
Edit Page > Adds a second valid sample, to use as a component Output Screenshots Video
Edit Page > Adds a third valid sample, to use as a component Output Screenshots Video
Edit Page > Checks editing the sample edit page Output Screenshots Video
Edit Page > adds a chemical formula to component1 Output Screenshots Video
Edit Page > adds some synthesis information Output Screenshots Video
Edit Page > deletes synthesis components and re-adds them Output Screenshots Video
Edit Page > tries to add a non-numeric value into quantity Output Screenshots Video
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Output Screenshots Video
Edit Page > cleanup: delete the samples Output Screenshots Video
Failed  sampleTablePage.cy.js • 16 failed tests

View Output Video

Test Artifacts
Sample table page > Adds a valid sample Screenshots Video
Sample table page > Checks if the sample is in the database Screenshots Video
Sample table page > Checks the sample edit page Screenshots Video
Sample table page > Attempts to Add an item with the same name Screenshots Video
Sample table page > Deletes a sample Screenshots Video
Sample table page > Adds several valid samples Screenshots Video
Advanced sample creation features > Adds some valid samples Screenshots Video
Advanced sample creation features > Adds a third sample copied from the first Screenshots Video
Advanced sample creation features > deletes the first sample and makes sure the copy is still there Screenshots Video
Advanced sample creation features > makes some more items for testing as components Screenshots Video
The first 10 failed tests are shown, see all 16 tests in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ml-evs
Copy link
Member Author

ml-evs commented Jul 27, 2023

Superseded by #404

@ml-evs ml-evs closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant