-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eval_results
decorator replacement
#755
Commits on Sep 23, 2024
-
rf: adjust patch to import and patch
eval_results
directlyPreviously the entrypoint for the patch was `_execute_command_()`. But now we aim to refactor the whole thing.
Configuration menu - View commit details
-
Copy full SHA for 83b7e4e - Browse repository at this point
Copy the full SHA 83b7e4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0c2826 - Browse repository at this point
Copy the full SHA a0c2826View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87197f6 - Browse repository at this point
Copy the full SHA 87197f6View commit details -
rf: remove needless separation of kwargs for command
Previously, kwargs for the actual command were handled semi-separately from kwargs for result handling. However, I see no benefits, only added complexity.
Configuration menu - View commit details
-
Copy full SHA for 1879453 - Browse repository at this point
Copy the full SHA 1879453View commit details -
`eval_func()` and its dependencies are a spaghetti monster. This commit introduces a `ResultHandler`, a class that provides functionality to handle results produced by a command execution. This idea is to factor out all result processing from result generation code. Moreover, a caller should eventually be able to provision an alternative result handler with different implementations for filtering, and rendering results.
Configuration menu - View commit details
-
Copy full SHA for 9d74654 - Browse repository at this point
Copy the full SHA 9d74654View commit details -
Configuration menu - View commit details
-
Copy full SHA for 829c179 - Browse repository at this point
Copy the full SHA 829c179View commit details -
chore: import the remainder of
eval_results
dependenciesThe aim is to jointly refactor them.
Configuration menu - View commit details
-
Copy full SHA for 6e52ccb - Browse repository at this point
Copy the full SHA 6e52ccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2436eba - Browse repository at this point
Copy the full SHA 2436ebaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe78fba - Browse repository at this point
Copy the full SHA fe78fbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c521ba - Browse repository at this point
Copy the full SHA 2c521baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dabd52 - Browse repository at this point
Copy the full SHA 2dabd52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46e30a9 - Browse repository at this point
Copy the full SHA 46e30a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02694ab - Browse repository at this point
Copy the full SHA 02694abView commit details -
rf: establish abstract base class
ResultHandler
And `LegacyResultHandler` as its only implementation for now.
Configuration menu - View commit details
-
Copy full SHA for 0a00832 - Browse repository at this point
Copy the full SHA 0a00832View commit details -
Configuration menu - View commit details
-
Copy full SHA for f180efe - Browse repository at this point
Copy the full SHA f180efeView commit details -
rf: separate result generation from handling of generated results
This is now done by a configurabled, dedicated handler class.
Configuration menu - View commit details
-
Copy full SHA for 3635941 - Browse repository at this point
Copy the full SHA 3635941View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29d7e4a - Browse repository at this point
Copy the full SHA 29d7e4aView commit details -
feat: dedicated getter/setter the global result handler
This replaces the initial implementation that would add yet another kwarg to each command. There is no real usecase for switching the result handler on a call-by-call basis. This new implementation follows the pattern found in libraries (like matplotlib) to set handlers or backends using top-level helper functions.
Configuration menu - View commit details
-
Copy full SHA for 392da52 - Browse repository at this point
Copy the full SHA 392da52View commit details -
ci: add setup for type/code checker
This anticipates a future move to `hatch` for project and environment management.
Configuration menu - View commit details
-
Copy full SHA for 0144f73 - Browse repository at this point
Copy the full SHA 0144f73View commit details -
fix: stop removing a
logger
attribute from the resultsThe helper `_execute_command_()` is not the place to decide on the fate of a results, or to impose any constraints on how it can be used. If a logger "does not serialize, or pollutes the output", this is only relevant, when a result needs to be serialized, or printed. Any sensible implementation of such functionality will need to have means to deal with this problem (a logger is not the only source of complications). Removing it here is therefore premature.
Configuration menu - View commit details
-
Copy full SHA for a2bf643 - Browse repository at this point
Copy the full SHA a2bf643View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4358cde - Browse repository at this point
Copy the full SHA 4358cdeView commit details -
fix: move
eval_results
patching to an earlier positionOtherwise it does not affect the remaining patches, like it should. One example is the `configuration` patch, which essentially replaces an entire command implementation.
Configuration menu - View commit details
-
Copy full SHA for ba9d2a4 - Browse repository at this point
Copy the full SHA ba9d2a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8368a0 - Browse repository at this point
Copy the full SHA d8368a0View commit details -
feat: sketch of a new configuration manager
This will eventually fix datalad#397
Configuration menu - View commit details
-
Copy full SHA for 154ca4d - Browse repository at this point
Copy the full SHA 154ca4dView commit details -
feat: add legacy compatibility layer to new configuration manager
This will eventually yield a near drop-in replacement for the legacy `ConfigManager`.
Configuration menu - View commit details
-
Copy full SHA for badbc4f - Browse repository at this point
Copy the full SHA badbc4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdad32b - Browse repository at this point
Copy the full SHA bdad32bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c76a7da - Browse repository at this point
Copy the full SHA c76a7daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61a60d3 - Browse repository at this point
Copy the full SHA 61a60d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21b70ea - Browse repository at this point
Copy the full SHA 21b70eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14bae3f - Browse repository at this point
Copy the full SHA 14bae3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55f2e20 - Browse repository at this point
Copy the full SHA 55f2e20View commit details