CNDB-12451 validate keyspace+table names length #1553
+52
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
|
Fixes CNDB-12451 and CNDB-12683. The length of table names wasn't validated for acceptable size for a file name, since the creation was invoking a validation function with similar name but without length validation. Furthermore, a file name is constructed by concatenating keyspace and table names through a separator. This was never validated if the combined name will be too large for a file name. This commit changes validations during table creations: - to validate table name to include the length validation; - to add validation of keyspace and table names combined; - to remove validation of keyspace name, which is already part of keyspace creation.
Use the validation function, which also checks the length of the name.
k-rus
force-pushed
the
rf-cndb-12683-long-table-file-name
branch
from
a867057 to
17b63f2
Compare
✔️ Build ds-cassandra-pr-gate/PR-1553 approved by ButlerApproved by Butler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
The length of table names were not validated for acceptable size for a
file name, since the creation was invoking a validation function with
similar name but without length validation.
Furthermore, a file name is constructed by concatenating keyspace and
table names through a separator. This was never validated if the
combined name will be too large for a file name.
What does this PR fix and why was it fixed
Fixes https://github.com/riptano/cndb/issues/12683, fixes https://github.com/riptano/cndb/issues/12451.
This commit changes validations during table creations:
CNDB's PR with this artifact: https://github.com/riptano/cndb/pull/12779