Update smoke test credential usage #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aosoriodw
approved these changes
Mar 14, 2024
| @@ -35,8 +38,8 @@ jobs: | |||
| distribution: ${{ matrix.clusters.distribution }} | |||
| version: ${{ matrix.clusters.version }} | |||
| kubeconfig: ${{ runner.temp}}/kubeconfig.yaml | |||
| kubeceptionToken: ${{ secrets.KUBECEPTION_TOKEN }} | |||
| gkeCredentials: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }} | |||
| kubeceptionToken: ${{ matrix.clusters.distribution == 'Kubeception' && env.KUBECEPTION_TOKEN }} | |||
There was a problem hiding this comment.
I'd prefer that the parameter was not set, in case there are issues handling missing parameters, but I think this works for now.
There was a problem hiding this comment.
Yeah, I just didn't want to redo all of these right now.
Ideally these are split apart with different sets of parameters, but it would take a bit of work to change/test these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mimics the change made to
matrix.yamlrecently. This ensures that both Kubeception credentials and GKE credentials are not simultaneously required for every cluster. This was a previous defect (that has now been fixed in #85) that was never caught due to the way these tests are structured.It's a slightly cheesy way of accomplishing this, but it's better than a more substantial rework of the testing.
Blast Radius
None.
Dependencies and documentation
Documentation
DEVELOPING.mdwith any dev tricks I used to work on this code efficiently.Monitoring
External dependencies
Rosie the Robot checklists
Testing
Testing Strategy
Existing tests.
Security
Related Issues or corrective actions
N/A
Deployment plan
Ensure test runs successfully after merge.