fix:spec command lists all available configuration fields #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hash-data
reviewed
Jan 30, 2025
| ServerRAM uint `json:"server_ram"` | ||
| MaxThreads int `json:"max_threads"` | ||
| Database string `json:"database"` | ||
| ServerRAM uint `json:"server_ram" validate:"required" gt:"0"` |
There was a problem hiding this comment.
remove server ram as it is not being used currently
| Database string `json:"database"` | ||
| ServerRAM uint `json:"server_ram" validate:"required" gt:"0"` | ||
| MaxThreads int `json:"max_threads" validate:"required" gt:"0"` | ||
| Database string `json:"database" validate:"required"` | ||
| DefaultMode types.SyncMode `json:"default_mode"` |
There was a problem hiding this comment.
it is also required default value must be full_refresh for it
| spec := make(map[string]interface{}) | ||
| if generate { |
There was a problem hiding this comment.
need to check purpose for generate. (adding comment for remembrance)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
spec command lists all available configuration fields
Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):