Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CH real estate companies #353

Merged
merged 12 commits into from
Sep 6, 2020

Conversation

ritterasdf
Copy link
Contributor

Added a list of suggested companies for the Swiss online real estate market (search engines, ad companies, etc). Directly added a few companies in the same realm as well.

companies/guidle.json Outdated Show resolved Hide resolved
companies/guidle.json Outdated Show resolved Hide resolved
companies/guidle.json Outdated Show resolved Hide resolved
companies/homegate.json Outdated Show resolved Hide resolved
companies/immostreet.json Outdated Show resolved Hide resolved
companies/immostreet.json Outdated Show resolved Hide resolved
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have left some comments below.

companies/immostreet.json Outdated Show resolved Hide resolved
companies/newhome.json Outdated Show resolved Hide resolved
companies/newhome.json Show resolved Hide resolved
companies/newhome.json Outdated Show resolved Hide resolved
companies/semsea.json Outdated Show resolved Hide resolved
companies/semsea.json Outdated Show resolved Hide resolved
companies/semsea.json Outdated Show resolved Hide resolved
companies/svit.json Outdated Show resolved Hide resolved
"immosky",
"remax",
"nzz-domizil",
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding suggested companies. I am not sure if these are the companies we are looking for, though. In
#230, there's an explanation of the companies we are looking for here:

With our suggested companies lists, we collect companies that have data on most people in their respected countries. Prominent examples for such companies include credit agencies and list brokers. We recommend sending GDPR access requests to all these companies.
This explicitly doesn't include companies that are relevant for many but not all users (like Google, Facebook, Amazon etc.)

I also listed some common categories of companies.

Correct me if I'm wrong but I don't think companies like Immowelt match these criteria. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @baltpeter, I wasn't quite sure if these companies would fit into the objective of datenanfragen. I created this list because there seems to be some kind of web of data exchange between many of the online real estate companies in Switzerland. This fact makes it hard to know where your information ends up, even if you only use one of the companies in question. I understand if you want to keep datenanfragen more towards list brokers - in that case, just reject my merge requests ;) Otherwise, I will fix the formatting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.

We are definitely interested in adding the companies. I just wouldn't want to add them to the suggested companies list for the reasons I gave.

I can definitely see what you wanted to achieve here, though. Maybe a better medium for this would be a blog post? Otherwise, let's just add the companies. :)

companies/svit.json Outdated Show resolved Hide resolved
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has been stale for almost a year now, I took the liberty of making the changes myself. :)

@baltpeter baltpeter merged commit c74abc8 into datenanfragen:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants