Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dataset creation user interface #13

Closed
wants to merge 1 commit into from

Conversation

mohamedsalem401
Copy link

@mohamedsalem401 mohamedsalem401 commented Apr 16, 2024

For https://github.com/datopian/client-sigma2-shared/issues/151
I applied the styles to the dataset creation flow.

image

@sagargg sagargg changed the base branch from sigma2 to sigma2-dev April 17, 2024 02:17
@sagargg
Copy link
Member

sagargg commented Apr 17, 2024

@mohamedsalem401 Actually you need to raise PR against sigma2-dev branch. I changed base branch but it has a conflict.

@mohamedsalem401
Copy link
Author

CLOSED. I opened a different PR for this #15
as it will be difficult to fix conflicts for dataset-creation-styles branch as I originally forked it off sigma2 branch and not sigma2-dev branch

@mohamedsalem401 mohamedsalem401 deleted the dataset-creation-styles branch April 17, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants