add test case for server sending GOAWAY before opening a stream #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
reviewed
Mar 28, 2022
Comment on lines
+279
to
+280
| local stream = c:new_stream() | ||
| assert.falsy(stream) |
There was a problem hiding this comment.
I think you should assert the particular error you get
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there - this is for issue #179 - it just adds a test case for what (I think) the expected behavior is - if a connection has received a GOAWAY frame before a stream is opened, then opening a stream should result in an error.
Happy to change if the expectation is elsewhere (that writing headers should be an error, or receiving should be an error)