Better protection for disposed pipe from caller

daveaglick · Sep 20, 2018 · a7a7ccd · a7a7ccd
1 parent 52a3068
commit a7a7ccd
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/src/MsBuildPipeLogger.Server/PipeLoggerServer.cs b/src/MsBuildPipeLogger.Server/PipeLoggerServer.cs
@@ -45,6 +45,10 @@ public PipeLoggerServer(PipeStream pipeStream)
                 {
                     // The client broke the stream so we're done
                 }
+                catch (ObjectDisposedException)
+                {
+                    // The pipe was disposed by the caller
+                }
 
                 // Add a final 0 (BinaryLogRecordKind.EndOfFile) into the stream in case the BuildEventArgsReader is waiting for a read
                 Buffer.Write(new byte[1] { 0 }, 0, 1);
@@ -69,20 +73,12 @@ public bool Read()
                 return false;
             }
 
-            try
+            BuildEventArgs args = _buildEventArgsReader.Read();
+            if (args != null)
             {
-                BuildEventArgs args = _buildEventArgsReader.Read();
-                if (args != null)
-                {
-                    Dispatch(args);
-                    return true;
-                }
+                Dispatch(args);
+                return true;
             }
-            catch (EndOfStreamException)
-            {
-                // Nothing else to read
-            }
-
             return false;
         }