Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker compose for development #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Fernando-Marquardt
Copy link

@Fernando-Marquardt Fernando-Marquardt commented Jun 23, 2024

This is my attempt of improving the current Docker image and Docker Compose setup for the project. The goal is to provide an easier setup when deploying to Docker, eliminating the need to run the installer.php.

These updates alsso enable the use of docker compose watch to update the container with the changed files after saving.

Cron jobs are also available within the same Docker image.

There are a few remaining issues, like the installer.php being included, giving the warning in the staff page. The CODE (called APP_KEY in the docker-compose file) previously randomly generated by the installer.php must be added manueally, following the instructions in the README file. And the admin user is created with default values and have to be changed after the first run.

All of these issues could be fixed by a new installer, that would support a full install (the usual CPanel intallation, where every config needs to be provided) and a partial install (the new Docker build, where only a few steps are needed).

Edit:

Added SSL configuration as well with instructions in the README file.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@davemacaulay
Copy link
Owner

@Fernando-Marquardt can you resolve the conflicts and I can go ahead and merge this

@Fernando-Marquardt
Copy link
Author

@Fernando-Marquardt can you resolve the conflicts and I can go ahead and merge this

Sure. The recent pull request introduced a change to the cron scripts to support running cronless and it is enabled by default. As a result, this change is not fully compatible with cron (easily fixable).

I will make a fix to keep cron functional when running with Docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants