Improve docker compose for development #5
+1,572
−1,334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt of improving the current Docker image and Docker Compose setup for the project. The goal is to provide an easier setup when deploying to Docker, eliminating the need to run the
installer.php
.These updates alsso enable the use of
docker compose watch
to update the container with the changed files after saving.Cron jobs are also available within the same Docker image.
There are a few remaining issues, like the
installer.php
being included, giving the warning in the staff page. The CODE (called APP_KEY in the docker-compose file) previously randomly generated by theinstaller.php
must be added manueally, following the instructions in the README file. And the admin user is created with default values and have to be changed after the first run.All of these issues could be fixed by a new installer, that would support a full install (the usual CPanel intallation, where every config needs to be provided) and a partial install (the new Docker build, where only a few steps are needed).
Edit:
Added SSL configuration as well with instructions in the README file.