Parser render module #530
Parser render module #530
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…de on parser since the ast is bonkers
…perty grammar definition
…t the test passes
| @@ -542,22 +532,28 @@ let handle_tokenizer_error = lexbuf => { | |||
| }; | |||
|
|
|||
| let skip_whitespace = ref(false); | |||
| let prev_skip_whitespace = ref(false); | |||
There was a problem hiding this comment.
whoa, I would need an explanation on why previous is needed, when we have skip_ws
There was a problem hiding this comment.
If both booleans are needed, I would go with a single ref and a few variants, wdyt?
Inside_media | Inside_selector | Outside_x | etc..
There was a problem hiding this comment.
oof forgot to refactor this specific hack hehe.
when we are inside a brace, the skip_whitespace is set to true and the whitespace inside values (<property>: <values>) is skipped. i want to enable whitespace when we are seeing : and bring skip_whitespace to its previous value when we are seeing ;
i like the variant idea though, will try to implement it!
| Styled_ppx_css_parser.Parser_location.update_pos_lnum( | ||
| at_rule_prelude_loc, | ||
| loc, | ||
| ), |
There was a problem hiding this comment.
When have you seen this to be needed? Can add a test for it? ^^
There was a problem hiding this comment.
this keeps the cnum of the first location but offset the lnum with the second loc. i've tried using intersection but this seems to work well to highlight the correct error location.
No description provided.