Scrollbar Module 1 and Partial Overflow Module 3 support #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
davesnx
approved these changes
Jan 24, 2025
| [%e render_color(~loc, thumbColor)], | ||
| [%e render_color(~loc, trackColor)], | ||
| ))] | ||
| | `Color(_) => raise(Unsupported_feature) |
There was a problem hiding this comment.
one color looks like isn't supported (can we change the spec definition to be instead?
There was a problem hiding this comment.
this path will not be reached i believe, since we are using the curly syntax <color>{2} the type will always be a list
There was a problem hiding this comment.
Can you add a comment (it's easy to discover in the future but faster with a small //)
There was a problem hiding this comment.
huh you know what, i think we can just use static instead
Comment on lines
+4327
to
+4337
| module Margin = struct | ||
| type t = | ||
| [ Length.t | ||
| | Var.t | ||
| ] | ||
|
|
||
| let toString x = | ||
| match x with | ||
| | #Length.t as l -> Length.toString l | ||
| | #Var.t as va -> Var.toString va | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #538