Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Issue 191 #192

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Conversation

DonVito1982
Copy link

Addresses #191

Copy link

@skylee03 skylee03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daviddarnes daviddarnes mentioned this pull request Dec 31, 2023
10 tasks
@daviddarnes daviddarnes changed the base branch from main to version5 January 2, 2024 23:27
@daviddarnes daviddarnes merged commit e0127a9 into daviddarnes:version5 Jan 2, 2024
@daviddarnes
Copy link
Owner

Thanks for this @DonVito1982! Have you considered making this same pull request to Sassline itself? The project isn't very active, but it appears pull requests do get in as @skylee03 was able to get theirs merged. If you do let me know as I'd like to keep the version of Sassline in Alembic as up to date as possible

@DonVito1982
Copy link
Author

Thanks for this @DonVito1982! Have you considered making this same pull request to Sassline itself? The project isn't very active, but it appears pull requests do get in as @skylee03 was able to get theirs merged. If you do let me know as I'd like to keep the version of Sassline in Alembic as up to date as possible

Sure. I'll give it a try and let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants