Skip to content

Commit

Permalink
fix: store paddings as numeric values and not integer values
Browse files Browse the repository at this point in the history
  • Loading branch information
davidgohel committed Aug 14, 2024
1 parent 9461342 commit 8baa5b4
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: officer
Title: Manipulation of Microsoft Word and PowerPoint Documents
Version: 0.6.6
Version: 0.6.7.001
Authors@R: c(
person("David", "Gohel", , "[email protected]", role = c("aut", "cre")),
person("Stefan", "Moog", , "[email protected]", role = "aut"),
Expand Down Expand Up @@ -60,4 +60,4 @@ Suggests:
testthat
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.1
RoxygenNote: 7.3.2
8 changes: 7 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
# officer 0.6.6.9000
# officer 0.6.7

## Issues

- store paddings as numeric values and not integer values.

# officer 0.6.6

## Issues

Expand Down
8 changes: 4 additions & 4 deletions R/formatting_properties.R
Original file line number Diff line number Diff line change
Expand Up @@ -663,16 +663,16 @@ fp_par <- function(text.align = "left",
)
)
if (!missing(padding.bottom)) {
out <- check_set_integer(obj = out, padding.bottom)
out <- check_set_numeric(obj = out, padding.bottom)
}
if (!missing(padding.left)) {
out <- check_set_integer(obj = out, padding.left)
out <- check_set_numeric(obj = out, padding.left)
}
if (!missing(padding.top)) {
out <- check_set_integer(obj = out, padding.top)
out <- check_set_numeric(obj = out, padding.top)
}
if (!missing(padding.right)) {
out <- check_set_integer(obj = out, padding.right)
out <- check_set_numeric(obj = out, padding.right)
}

out <- check_set_numeric(obj = out, line_spacing)
Expand Down

0 comments on commit 8baa5b4

Please sign in to comment.