Implement BYSETPOS #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few small updates to Nicolas Marlier's BYSETPOS support added in PR ice-cube-ruby#349
davidstosik
commented
Feb 8, 2019
| def rule_hash_for_all_occurrences | ||
| source_rule.to_hash.except(:count, :until).tap do |hash| | ||
| if hash[:validations] | ||
| hash[:validations].delete(:by_set_pos) |
There was a problem hiding this comment.
Note to self: this could be hash[:validations]&.delete(:by_set_post). Not sure about the Ruby version requirements though... 🤔
|
@davidstosik I'm curious about this branch's progress. any way I might help ? |
|
2.5 years later and this still hasn't been merged.. is this gem even maintained anymore? |
|
This PR was only ever meant to trigger Travis. Still waiting on feedback in the original repo: Closing this now, so please head over there if you have questions/requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test, rebased on
master, to see how Travis goes (all builds should be able to run but fail onspec/examples/yearly_rule_spec.rb:80).