Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dlib::expected #2827

Closed
wants to merge 74 commits into from
Closed

dlib::expected #2827

wants to merge 74 commits into from

Commits on Jul 10, 2023

  1. WIP. This crazy complicated if you follow the standard to the letter

    pf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    9766f0d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. constructors done

    pf committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    30ddedd View commit details
    Browse the repository at this point in the history

  2. WIP

    pf committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    7d41a0c View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. iterative impl and tests

    pf committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    a549365 View commit details
    Browse the repository at this point in the history

  2. progress

    pf committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    f34fa0a View commit details
    Browse the repository at this point in the history

  3. ambigous fix

    pf committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    da08279 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into expected

    pf committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    bb5bea2 View commit details
    Browse the repository at this point in the history

  5. progress

    pf committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    4266fc5 View commit details
    Browse the repository at this point in the history

  6. added as_const(). That's a C++17 feature. So needed another backport

    pf committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    3409225 View commit details
    Browse the repository at this point in the history

  7. check for T==void

    pf committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    47a6a9b View commit details
    Browse the repository at this point in the history

  8. added disjunction, properly handle case T==void

    pf committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    97a1fc2 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. wip

    pf committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    9e9a727 View commit details
    Browse the repository at this point in the history

  2. work with gcc 7.5

    Your Name committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    52b86c4 View commit details
    Browse the repository at this point in the history

  3. wip

    Your Name committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    cabbedd View commit details
    Browse the repository at this point in the history

  4. wip

    Your Name committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    087ea40 View commit details
    Browse the repository at this point in the history

  5. compile time stuff

    Your Name committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    5ce6d79 View commit details
    Browse the repository at this point in the history

  6. mainly type traits

    Your Name committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    33a5bab View commit details
    Browse the repository at this point in the history

  7. an extra assignment operator. jesus, this is a headache. I doubt Davi… 

    …s will be bothered to review this. This isn't a 2 hour job.
    Your Name committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    b880675 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. noexcept

    Your Name committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    a3096a2 View commit details
    Browse the repository at this point in the history

  2. emplace()

    Your Name committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    8ed8a38 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. poshing up

    Your Name committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    49c6652 View commit details
    Browse the repository at this point in the history

  2. oops

    Your Name committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    43c7b04 View commit details
    Browse the repository at this point in the history

  3. tidying

    Your Name committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    d3ef79e View commit details
    Browse the repository at this point in the history

  4. - corrected docs 

    - added and_then() NOT tested yet
    Your Name committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    cb75913 View commit details
    Browse the repository at this point in the history

  5. more tests

    Your Name committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    8df2759 View commit details
    Browse the repository at this point in the history

  6. more tests

    Your Name committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    9b635b2 View commit details
    Browse the repository at this point in the history

  7. bug fixes and more tests

    Your Name committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e52ebd2 View commit details
    Browse the repository at this point in the history

  8. more tests

    Your Name committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    1336d12 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. make sure you call the right constructor for the second base class. Y… 

    …ou don't want to be accidentally calling a default constructor. Call a dummy constructor that does nothing and bypasses.
    Your Name committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2acb6ad View commit details
    Browse the repository at this point in the history

  2. more tests

    Your Name committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    078dbc5 View commit details
    Browse the repository at this point in the history

  3. added swap() and tests

    Your Name committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    08406d3 View commit details
    Browse the repository at this point in the history

  4. SFINAE and noexcept specification on swap(). Holy macaroni

    Your Name committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    0c6d7de View commit details
    Browse the repository at this point in the history

  5. added transform()

    Your Name committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    e06a105 View commit details
    Browse the repository at this point in the history

  6. Update expected.h

    @pfeatherstone
    pfeatherstone authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    c451c8a View commit details
    Browse the repository at this point in the history

  7. more tests

    Your Name committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    70ff489 View commit details
    Browse the repository at this point in the history

  8. more tests and bug fixes for the converting constructors

    Your Name committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    c48e991 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. fixed monads. added tests

    Your Name committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a8539b8 View commit details
    Browse the repository at this point in the history

  2. added tests for transform

    Your Name committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b3d51cb View commit details
    Browse the repository at this point in the history

  3. supress clang warnings

    Your Name committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6c845c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. more tests for monads. I think i've made the implementations simpler.… 

    … Making heavy use of switch_(). I hope the compilation speeds of switch_() statements is reasonable...
    pf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e0eee7e View commit details
    Browse the repository at this point in the history

  2. woops

    pf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    fb5698f View commit details
    Browse the repository at this point in the history

  3. added transform_error(). That's the end of the monads give or take bu… 

    …g fixes
    pf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    05ef1e1 View commit details
    Browse the repository at this point in the history

  4. operator== added

    pf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    577e025 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. potentially better code gen - less branches

    pf committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    617081b View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. wip

    pf committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    8558be0 View commit details
    Browse the repository at this point in the history

  2. more tests

    pf committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    4e98cab View commit details
    Browse the repository at this point in the history

  3. bug fix and more tests

    pf committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    0f66144 View commit details
    Browse the repository at this point in the history

  4. more tests

    pf committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    895af66 View commit details
    Browse the repository at this point in the history

  5. more tests

    pf committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c3c51f4 View commit details
    Browse the repository at this point in the history

  6. more tests

    pf committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    319daf6 View commit details
    Browse the repository at this point in the history

  7. more tests

    pf committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    eeddde9 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. more tests

    pf committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    bd91720 View commit details
    Browse the repository at this point in the history

  2. don't actually need an empty dummy struct in the union.

    pf committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    a2c9353 View commit details
    Browse the repository at this point in the history

  3. strong exception guarantee of assignment operators. Needs testing

    pf committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    82dbdd9 View commit details
    Browse the repository at this point in the history

  4. more strong exception guarantees and tests

    pf committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e1bcbda View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. added more tests

    pf committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    5c0aec1 View commit details
    Browse the repository at this point in the history

  2. - make tidy 

    - trying to fix with gcc 7.5. Willing to bet there is a bug in gcc7.5
    Your Name committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    f26b3dc View commit details
    Browse the repository at this point in the history

  3. more tests

    Your Name committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    9bb80b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. - added very useful type trait : is_specialization_of

    Your Name committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    2536fdb View commit details
    Browse the repository at this point in the history

  2. more tests. Not finished. Something is broken when T == void

    Your Name committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    662b39e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. - added is_specialization_of<> type trait. It's super useful and actu… 

    …ally proposed to be standardised
    pf committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    9249120 View commit details
    Browse the repository at this point in the history

  2. - use is_specialization_of 

    - a few fixes
- a shit ton more tests
    pf committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    b959f5f View commit details
    Browse the repository at this point in the history

  3. operator!=

    pf committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    4e58ba9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into expected

    pf committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    91718e9 View commit details
    Browse the repository at this point in the history

  5. maybe better

    pf committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    57669e9 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'expected' of github.com:pfeatherstone/dlib into expected

    pf committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    a9863e3 View commit details
    Browse the repository at this point in the history

  7. bug fix

    Your Name committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    d0a565f View commit details
    Browse the repository at this point in the history

  8. static_asserts disabled

    Your Name committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    cc7d884 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2023

  1. - making switch_() happy 

    - need to fix these static asserts
    pf committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    9e43a5a View commit details
    Browse the repository at this point in the history

  2. removed if constexpr. Not needed here

    pf committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    270edc5 View commit details
    Browse the repository at this point in the history

  3. disabled more static asserts. I'm confused. I thought i disabled all … 

    …of them...
    Your Name committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    b2a2471 View commit details
    Browse the repository at this point in the history

  4. disabled yet another static assert

    Your Name committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    4f2cf49 View commit details
    Browse the repository at this point in the history

  5. store the error type directly, not unexpected. Still makes no differe… 

    …nce to solving all those disabled static asserts
    Your Name committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    d73380d View commit details
    Browse the repository at this point in the history

  6. trying to debug MSVC error on windows-latest

    Your Name committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    351d3c1 View commit details
    Browse the repository at this point in the history