Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spinner when tailscale takes longer than ususal #1140

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

lbrecic
Copy link
Contributor

@lbrecic lbrecic commented Sep 23, 2024

Add spinner when tailscale takes longer than ususal

Description

This PR introduces a spinner with a timeout and appropriate error message if tailscale takes more than usual to create a connection.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

Closes #450

@lbrecic lbrecic requested a review from a team as a code owner September 23, 2024 20:53
pkg/cmd/workspace/create.go Outdated Show resolved Hide resolved
pkg/cmd/workspace/create.go Outdated Show resolved Hide resolved
@lbrecic lbrecic force-pushed the add-tsnet-conn-spinner branch 2 times, most recently from bdadcba to b2587cf Compare September 25, 2024 10:04
@lbrecic lbrecic marked this pull request as draft September 25, 2024 10:15
@lbrecic lbrecic marked this pull request as ready for review September 26, 2024 09:29
@lbrecic lbrecic merged commit 57a4bb5 into main Sep 27, 2024
12 checks passed
@lbrecic lbrecic deleted the add-tsnet-conn-spinner branch September 27, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display tailscale connection delays in workspace creation
3 participants