Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto install remote SSH extension in vscode #1142

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

tarunrajput
Copy link
Contributor

@tarunrajput tarunrajput commented Sep 24, 2024

auto install remote SSH extension in vscode

Description

auto install remote SSH extension if it is not already installed in user's vscode

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

closes #1094

@tarunrajput tarunrajput requested a review from a team as a code owner September 24, 2024 15:25
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please apply this to Cursor as well.

@tarunrajput
Copy link
Contributor Author

Looks good but please apply this to Cursor as well.

sure

@tarunrajput
Copy link
Contributor Author

@Tpuljak, I can't seem to install any extension using cursor binary. Can you confirm if it is working for you?

image

@Tpuljak
Copy link
Member

Tpuljak commented Sep 25, 2024

@Tpuljak, I can't seem to install any extension using cursor binary. Can you confirm if it is working for you?

image

Screenshot 2024-09-25 at 10 21 35

@tarunrajput I believe the issue for you is that Cursor is using https://open-vsx.org/ as a marketplace now. Can you try to install another extension (that is not owned my Microsoft)?

@tarunrajput
Copy link
Contributor Author

@Tpuljak, I can't seem to install any extension using cursor binary. Can you confirm if it is working for you?
image

Screenshot 2024-09-25 at 10 21 35

@tarunrajput I believe the issue for you is that Cursor is using open-vsx.org as a marketplace now. Can you try to install another extension (that is not owned my Microsoft)?

Yes, installing extensions from other publishers works.

@Tpuljak
Copy link
Member

Tpuljak commented Sep 25, 2024

Yes, installing extensions from other publishers works.

Yeah... Can't do much here it seems. Does opening a Daytona workspace with Cursor even work for you now?

@tarunrajput
Copy link
Contributor Author

Yes, installing extensions from other publishers works.

Yeah... Can't do much here it seems. Does opening a Daytona workspace with Cursor even work for you now?

Yes, I was able to install the extension via the prompt that appears when we try to open a remote session.

@Tpuljak
Copy link
Member

Tpuljak commented Sep 25, 2024

Yes, I was able to install the extension via the prompt that appears when we try to open a remote session.

Ah, okay. Then we can leave cursor out of this PR.

Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@lbrecic
Copy link
Contributor

lbrecic commented Sep 25, 2024

@tarunrajput everything seems to be working as expected, nicely done!
Let's just add a line to the output which informs user that extension is installed once it is and we'll be good to go.

@tarunrajput
Copy link
Contributor Author

@tarunrajput everything seems to be working as expected, nicely done! Let's just add a line to the output which informs user that extension is installed once it is and we'll be good to go.

done

@lbrecic lbrecic merged commit 9cbfd4a into daytonaio:main Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daytona should auto-install the Remote SSH extension in VS Code
3 participants