refactor: server start #1196
Open
refactor: server start #1196
+213
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- headscale, local container registry and the api server are responsible for their own FRP connection - headscale and local CR are started in the entrypoint rather than in the server start method Signed-off-by: Toma Puljak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Server Start
Description
This is a small logical refactor that moves responsibility of starting the FRP connection into their respective components. Additionally, starting the headscale server and local CR is now done in the entrypoint (
serve) rather than in the server start method. Since those components are self-contained, they should be started outside of the server and provided as a dependency to the server itself. This will also enable us to connect to external headscale servers since the Daytona server won't manage one by itself.