Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows images in Daytona workspaces #1346

Closed

Conversation

vishwamartur
Copy link

Related to #1339

Add support for Windows images in Daytona to create workspaces in a Windows environment.

  • Devcontainer Configuration

    • Add a new feature for Windows images using ghcr.io/devcontainers/features/windows:1 in hack/project_image/.devcontainer/devcontainer.json
    • Update the overrideFeatureInstallOrder to include the new Windows feature
  • Server Configuration

    • Add an option to configure Windows images in the configureCmd in pkg/cmd/server/configure.go
    • Update the apiServerConfig to include Windows image configuration
  • Workspace Creation

    • Add support for creating workspaces with Windows images in the CreateCmd in pkg/cmd/workspace/create.go
    • Update the processPrompting function to handle Windows image options
    • Add a flag for Windows image support in the workspace creation command
  • Project Configuration

    • Add logic to handle Windows images in the GetProjectsCreationDataFromPrompt function in pkg/cmd/workspace/util/creation_data.go
    • Update the ProjectConfigDefaults to include Windows image defaults

@vishwamartur vishwamartur requested a review from a team as a code owner November 18, 2024 06:36
Related to daytonaio#1339

Add support for Windows images in Daytona to create workspaces in a Windows environment.

* **Devcontainer Configuration**
  - Add a new feature for Windows images using `ghcr.io/devcontainers/features/windows:1` in `hack/project_image/.devcontainer/devcontainer.json`
  - Update the `overrideFeatureInstallOrder` to include the new Windows feature

* **Server Configuration**
  - Add an option to configure Windows images in the `configureCmd` in `pkg/cmd/server/configure.go`
  - Update the `apiServerConfig` to include Windows image configuration

* **Workspace Creation**
  - Add support for creating workspaces with Windows images in the `CreateCmd` in `pkg/cmd/workspace/create.go`
  - Update the `processPrompting` function to handle Windows image options
  - Add a flag for Windows image support in the workspace creation command

* **Project Configuration**
  - Add logic to handle Windows images in the `GetProjectsCreationDataFromPrompt` function in `pkg/cmd/workspace/util/creation_data.go`
  - Update the `ProjectConfigDefaults` to include Windows image defaults

Signed-off-by: Vishwanath Martur <[email protected]>
@Tpuljak
Copy link
Member

Tpuljak commented Nov 19, 2024

@vishwamartur submitting untested, unbuildable PRs is not acceptable.

I imagine this is something AI generated judging from the PR description.
Every PR you submit must be thoroughly tested before requesting a review.

@Tpuljak Tpuljak closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants