Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: project uptime #382

Merged
merged 1 commit into from
Apr 12, 2024
Merged

feat: project uptime #382

merged 1 commit into from
Apr 12, 2024

Conversation

Tpuljak
Copy link
Member

@Tpuljak Tpuljak commented Apr 11, 2024

Project Uptime

Description

This PR introduces project uptime that is periodically set by the agent. This removes the need for providers to track uptime numbers.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Related Issue(s)

Closes #379

Copy link
Member

@idagelic idagelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out, looks good

pkg/views/workspace/selection/workspace.go Show resolved Hide resolved
Uptime is set periodically by the agent.
Additionally, removed unnecessary properties from the ProjectInfo struct.

Signed-off-by: Toma Puljak <[email protected]>
Copy link
Member

@vedranjukic vedranjukic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Tpuljak Tpuljak merged commit 93f1f93 into main Apr 12, 2024
4 checks passed
@Tpuljak Tpuljak deleted the project-uptime branch April 12, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project uptime
3 participants