Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: project post start commands #430

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat: project post start commands #430

merged 1 commit into from
Apr 25, 2024

Conversation

Tpuljak
Copy link
Member

@Tpuljak Tpuljak commented Apr 24, 2024

Project Post Start Commands

Description

This PR introduces the PostStartCommands property into the project model. This property holds commands that the agent inside the project once it has been started.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Notes

This change will require users to run daytona server configure and add sudo dockerd as a default start command once the Docker Provider is updated to not include starting dockerd by itself.

@Tpuljak Tpuljak requested review from a team as code owners April 24, 2024 13:58
@Tpuljak Tpuljak self-assigned this Apr 24, 2024
@Tpuljak Tpuljak marked this pull request as draft April 24, 2024 15:52
@Tpuljak
Copy link
Member Author

Tpuljak commented Apr 24, 2024

Flagged as draft. I want to implement better logging of the commands to allow the user to view the logs inside the workspace.

@Tpuljak Tpuljak marked this pull request as ready for review April 25, 2024 07:37
@Tpuljak
Copy link
Member Author

Tpuljak commented Apr 25, 2024

Flagged as draft. I want to implement better logging of the commands to allow the user to view the logs inside the workspace.

Decided to open #431 instead. The post start command logs will be part of the agent logs.

@Tpuljak Tpuljak marked this pull request as draft April 25, 2024 09:24
@Tpuljak
Copy link
Member Author

Tpuljak commented Apr 25, 2024

Drafted until #432 is merged and rebased.

@Tpuljak Tpuljak marked this pull request as ready for review April 25, 2024 13:23
@Tpuljak Tpuljak merged commit cf8bb43 into main Apr 25, 2024
5 checks passed
@Tpuljak Tpuljak deleted the post-start-commands branch April 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants