Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a root user check on serve #864

Merged
merged 3 commits into from
Aug 1, 2024
Merged

fix: add a root user check on serve #864

merged 3 commits into from
Aug 1, 2024

Conversation

Tpuljak
Copy link
Member

@Tpuljak Tpuljak commented Jul 30, 2024

Add a Root User Check on Serve

Description

Added a root user check when starting the server to inform the user that we recommend running as a non-root user.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

Closes #749

@Tpuljak Tpuljak requested a review from a team as a code owner July 30, 2024 13:19
pkg/cmd/server/serve.go Outdated Show resolved Hide resolved
Signed-off-by: Toma Puljak <[email protected]>
@Tpuljak Tpuljak requested a review from idagelic August 1, 2024 08:04
pkg/cmd/server/serve.go Outdated Show resolved Hide resolved
Signed-off-by: Toma Puljak <[email protected]>
@Tpuljak Tpuljak merged commit dfe9466 into main Aug 1, 2024
12 checks passed
@Tpuljak Tpuljak deleted the root-user-check branch August 1, 2024 13:30
the-johnwick pushed a commit to the-johnwick/daytona that referenced this pull request Aug 12, 2024
Signed-off-by: Toma Puljak <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
the-johnwick pushed a commit to the-johnwick/daytona that referenced this pull request Aug 13, 2024
the-johnwick pushed a commit to the-johnwick/daytona that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running daytona server as root may mean the workspace files are owned by root
3 participants